Block Editor: Use optional chaining in 'block-list' component #42068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amustaque97
approved these changes
Jul 1, 2022
Mamaduka
changed the title
|
Thanks for contributing, @hz-tyfoon. Both code variants are valid so I would call this a "code modernization." If you check the codebase, you'll find a lot of similar examples. But I don't think it's worth our time and effort to refactor the code that's working. I would recommend reading WordPress' Code Refactoring handbook for more details - https://make.wordpress.org/core/handbook/contribute/code-refactoring/. |
bph
added
[Type] Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hey Everyone. 🙂
Looks like in line number 59 & 62 there's 4
&& checkcan be replaced with 2optional chaining (?.).Why?
(
?.) already used in line number 190 of this file (packages/block-editor/src/components/block-list/block.js) and many other files in this repository. So, I think (?.) can be used where applicable.