Create Block: Fix regression from _.size() refactoring
#42049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Bug
This was referenced Jun 29, 2022
tyxla
force-pushed
the
fix/create-block-length-regressions
branch
from
67a42c8 to
671c002
Compare
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes #42047 - a regression, introduced by a recent Lodash migration.
Why?
This fixes a regression that came from #41810 as part of the Lodash migration work.
How?
Double-checking the potentially undefined arguments before using them.
Testing Instructions
npx @wordpress/create-block example-blockand make sure that the process finishes correctly and you see the list of commands at the end.create-blockchecks pass.