Update site editor region labels to match post editor #42037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Task
|
Size Change: +115 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jul 1, 2022
| body: __( 'Editor content' ), | ||
| /* translators: accessibility text for the editor settings landmark region. */ | ||
| sidebar: __( 'Editor settings' ), | ||
| /* translators: accessibility text for the editor footer landmark region. */ |
There was a problem hiding this comment.
I think we should also update the actions landmark region label. Currently, it says "Publish".
gutenberg/packages/edit-post/src/components/layout/index.js
Lines 60 to 61 in f2888ed
There was a problem hiding this comment.
I wasn't sure about this one. My thinking was that 'publish' isn't quite the right term in the site editor, but I didn't realise the default is already 'publish' 😄 . I thought it would be 'Actions'.
Thanks for reviewing.
There was a problem hiding this comment.
Good point! I'm not sure what label will work for both editors.
There was a problem hiding this comment.
I'll keep it as 'Editor publish' for now as I don't have any better ideas.
talldan
force-pushed
the
update/site-editor-region-labels
branch
from
a52aa16 to
81c8f9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the site editor's region labels to match the post editor
Why?
The site editors labels were different for some reason.
Making them match the post editor is a good idea as it helps make the site editor experience familiar for screen reader users that already know the post editor.
It also makes it easier to write end to end test utilities that work across both editors.
How?
Add the strings, innit.
Testing Instructions
Expected: the labels for the editor topbar, editor settings, editor content and editor footer should match.