-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment template: left, center and right alignments #41892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinan
added
[Type] Bug
An existing feature does not function as intended
[Block] Comment Template
Affects the Comment Template Block
labels
Jun 23, 2022
Size Change: +237 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
michalczaplinski
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @carolinan! 🙂
Tested and works as described 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Comment Template
Affects the Comment Template Block
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds CSS for left, center and right alignments to the comment template block.
Closes #40269
Why?
The comment template did not align to the left, center or right on the front when the toolbar alignment options were enabled.
Testing Instructions
Apply the PR.
Create a new post or page in the block editor.
Add a 3 comment blocks.
Select the inner comment template blocks and align one to left, one to center, and one to right.
Confirm that the alignments work in the editor.
Save and view the result on the front, confirm that the alignments work on the front.
Optionally, move the comment template block to different positions inside the comment query block, and test with different inner blocks inside the comment template. Confirm that the alignments still work.
Screenshots or screencast
Using empty theme:
Left. Not pretty, but it works:
Center:
Right: