Layout: Move generation of util classes to existing method to avoid adding global public method WP #41885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obal public method WP
glendaviesnz
added
the
CSS Styling
andrewserong
added
the
[Type] Code Quality
andrewserong
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Thanks for following up @glendaviesnz:
✅ Code change looks good, class names are still rendering in the editor and on the site front end
✅ Orientation works as expected
✅ Content justification works as expected
✅ is-nowrap class is added when expected
LGTM!
37 tasks
mburridge
added
the
Needs Dev Note
|
Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
glendaviesnz
added
Needs Dev Note
|
Thought it didn't need a dev note, but maybe it does, depends if the utility classnames is covered elsewhere or not, will try and work that out |
|
Relevant details about this will be covered in dev note for #40875 |
glendaviesnz
removed
the
Needs Dev Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Moves adding several layout utility classnames to blocks that have layout attributes specified into
gutenberg_render_layout_support_flaginstead of own method.Why?
To avoid adding a potentially temporary method to global
wp_scope in 6.0.1 release.How?
Copy pasta from one place to another
Testing Instructions
is-content-justification-centerandis-nowrapclasses are added in editor and frontendScreenshots or screencast