Handle cases when getBlockType returns undefined #41884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Added a few checks to determine if result of
getBlockType
is defined.Why?
As reported in #34462 ,
getBlockType
selector might returnundefined
and in few places it was assumed that it would return an object.How?
In places that were assuming that result of
getBlockType
is an object I have added some checks to make sure that case when it'sundefined
is handled too.I get no errors on the console but I see a "null" block after running
wp.data.dispatch('core/blocks').removeBlockTypes('core/missing')
and clicking on the block. Not sure if it's correct or not.Testing Instructions
Test instructions can be found here.