Navigation component: Prevent title and href props from being rendered as HTML attributes. #41833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: +4 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
afercia
force-pushed
the
fix/navigation-item-props-as-html-attributes
branch
from
4b9f6bf to
6728eb4
Compare
|
Updated to remove |
tyxla
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In the Navigation component, the
<li>elements render a title attribute and a href attribute:<li>element is invalid HTML.Why?
<li>element is just invalid HTML.How?
This PR uses lodash
omitto removetitleandhreffrom the passed props.Worth noting the
<li>element is a styled component. I'm not sure it actually needs the passedrestProps.Testing Instructions
<li>elements that contain the links don't have a title and href attribute.Screenshots or screencast
Screenshot with the unnecessary HTML attributes rendered and title attribute 'tooltip' visible on hover:
It happens also when the item is 'text only'. Screenshot from the storybook: