Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UrlInput: Decode Post Title special chars #4169

Merged
merged 1 commit into from
Dec 28, 2017

Conversation

youknowriad
Copy link
Contributor

closes #3877

This PR decodes the HTML characters of the "Post Title" in the URL Link Suggestions

Testing instructions

  • Create a post with quotes in the title
  • Publish the post
  • Try to add a link to this post from another post
  • The original post's title should show up properly in the suggestions.

@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Dec 26, 2017
@youknowriad youknowriad self-assigned this Dec 26, 2017
Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 works a treat.

Unrelated, but when I insert a link without having any text selected, the link is inserted within no text inside the <a>:

link-bug

@youknowriad youknowriad merged commit 3a3c3d5 into master Dec 28, 2017
@youknowriad youknowriad deleted the fix/url-link-suggestions branch December 28, 2017 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links suggestions: quotes in the post title get encoded
2 participants