Components: limit Dropdown cleanup to renders where the menu has actually been opened
#41604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chad1008
added
[Package] Components
|
Size Change: +4 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
mirka
approved these changes
Jun 9, 2022
chad1008
force-pushed
the
components/update-dropdown-useEffect
branch
from
c377598 to
0b909d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Followup to #41505 (comment)
This PR ensures that the
Dropdowncomponent doesn't run its cleanup (i.e, close the dropdown) unless the dropdown is actually open.How?
Add a check against the
isOpenprop, which is consistent with the component behavior prior to a previous refactorTesting Instructions
Dropdowncomponent in Storybooknpx eslint --rule 'react-hooks/exhaustive-deps: warn' packages/components/src/dropdownto ensure we're staying compliant there