Migrate wp editor meta box test to Playwright #41519
Conversation
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @Rink9! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Rink9
changed the title
|
@ntwb It seems CI are failing here can you please help me by reviewing this PR? |
|
Hi, @kevin940726 Can you please help me with reviewing this PR? It seems CI are failing here, what will be the nest step to move forward? Thanks :) |
|
Hi @Rink9! You can click on the "Details" link next to the CI check to see exactly where it fails. For instance, clicking on the "Details" link of the "Static Analysis" check will show you that it fails on linting the JavaScript code. You can then go and fix that if it's related to your changes. You can see the testing guideline for more detailed information. GLHF! |
|
@kevin940726
|
|
@Rink9 Those are only warnings and exist on The ones that fail the check are the errors in the report. You can scroll to the very bottom of the report and see that there's |
Rink9
force-pushed
the
add/playwright-wp-editor-meta-box-test
branch
from
6ff3df5 to
6c9d981
Compare
|
Hello @kevin940726, I have solved the problem with failing CI. Would you be able to take a look and review my PR? Please let me know if any further steps are necessary from my end. |
There was a problem hiding this comment.
Hi! Have you read the migration guide and the best practices? It's recommended to follow the best practices while migrating the tests so that we can leverage the full power of Playwright. It means that in most cases you have to understand exactly what the tests do (or are trying to do) and modify them accordingly. The most common modifications involve changing to use role selectors and using the locator API. It could be quite difficult in some cases though, feel free to ping us if you have encountered any questions! ;)
Rink9
force-pushed
the
add/playwright-wp-editor-meta-box-test
branch
from
97a7aab to
08dbdd8
Compare
|
Hi, @kevin940726 I addressed your feedbacks regarding |
|
@kevin940726 Sorry for pinging you again.... Any updates related to this PR? |
|
Hi @talldan Can you please take e look and review the PR? |
There was a problem hiding this comment.
Thanks for working on this! I left a couple of comments.
One other thing missing is that the old test file (https://github.com/WordPress/gutenberg/blob/trunk/packages/e2e-tests/specs/editor/plugins/wp-editor-meta-box.test.js) also needs to be deleted as part of this PR.
|
Hi @talldan Thanks for your feedback! I have addressed your reviews. Can you please check once? |
|
Hi @talldan @kevin940726 If anyone can arrange some time, could you please kindly check this PR? |
talldan
added
the
[Type] Automated Testing
|
I mentioned it in a DM to @Rink9, but mentioning it here as well for transparency. I think there's still one thing to address on the PR - it looks like the old test file still needs to be deleted. Although I'm seeing it deleted in 3501674, I still can't see this change in the 'Files Changed' tab for the PR. Not sure why that would be, but hopefully it can be fixed. |
Rink9
force-pushed
the
add/playwright-wp-editor-meta-box-test
branch
from
05916e9 to
3501674
Compare
|
Hi @talldan I just have fixed this file changed problem. Can you please take a look and share feedback? |
|
@talldan Thank you so much for your quick response. 😊 |
What?
Migrate wp-editor-meta-box.test.js to its Playwright version.
Why?
See #38570 for its background and rationale.
How?
See MIGRATION.md for migration steps.
Testing Instructions
npm run test-e2e:playwright test/e2e/specs/editor/plugins/wp-editor-meta-box.spec.jsScreencast
Screen.Recording.2022-06-03.at.12.48.47.AM.mov