Blocks: Remove no longer used Block Content Context #41395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -149 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
gziolo
force-pushed
the
remove/block-content-context
branch
from
84d6572 to
dfd2c75
Compare
gziolo
commented
Jul 8, 2022
| @@ -902,12 +902,18 @@ _Returns_ | |||
|
|
|||
| ### withBlockContentContext | |||
|
|
|||
| > **Deprecated** | |||
There was a problem hiding this comment.
@ryanwelcher, it looks like we still show deprecated APIs in documentation because the @wordpress/docgen tool doesn't skip them.
gziolo
requested review from
a team,
youknowriad and
aristath
and removed request for
a team
adamziel
approved these changes
Jul 8, 2022
mburridge
added
the
Needs Dev Note
|
Added the Needs Dev Note label in case this needs a dev note (either individual or as part of a "misc" dev note) for WP 6.1 release. |
|
It could get mentioned as one sentence in a bigger dev note, but I don't expect this API is important from the extenders' perspective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
withBlockContentContextis no longer used as of #26031.Why?
__unstableGetInnerBlocksPropsgo introduced in@wordpress/blocksto fulfill the same role aswithBlockContentContextplayed in the past.How?
We keep the public API and return the same component. If it is used, it will show the deprecation message on the Browser Console.