-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a zoomed out view to the site editor #41156
Changes from all commits
1a14570
a05a2e7
8c93805
ea8073e
6e50a75
c0d9e24
5db5274
812a4f6
a0addbf
270fe82
da48c0c
21b6831
d22c33c
b2bf41f
d2ea2ab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,8 +26,8 @@ function listener( event ) { | |
*/ | ||
export function useIsHovered() { | ||
const isEnabled = useSelect( ( select ) => { | ||
const { isNavigationMode, getSettings } = select( blockEditorStore ); | ||
return isNavigationMode() || getSettings().outlineMode; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the effect of this change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually this seems to be related with this one: https://github.com/WordPress/gutenberg/pull/41156/files#diff-28c09e3ec5ce812113676dc711c85ce1c1596361ec12bdecc038adee432eb787R22, that actually change how the hover of other blocks is styled. Trunk: Screen.Recording.2022-08-29.at.5.20.49.PM.movHere: Screen.Recording.2022-08-29.at.5.20.31.PM.movI'm not sure if that was discussed? Do you have any thoughts on this @jasmussen ? |
||
const { getSettings } = select( blockEditorStore ); | ||
return getSettings().outlineMode; | ||
}, [] ); | ||
|
||
return useRefEffect( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! :)