Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Theme Export: Use basename when determining the theme slug #41058

Merged
merged 1 commit into from
May 13, 2022
Merged

[bug] Theme Export: Use basename when determining the theme slug #41058

merged 1 commit into from
May 13, 2022

Conversation

scruffian
Copy link
Contributor

What?

As suggested in #40829 (comment) we should use basename to determine the theme slug.

Why?

  • Less code
  • Better compatibility with other environments

Testing Instructions

Export your theme from the Site Editor and check that the zip has the correct theme name.

@scruffian scruffian added [Type] Bug An existing feature does not function as intended [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Full Site Editing labels May 13, 2022
@scruffian scruffian self-assigned this May 13, 2022
gziolo
gziolo approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for the update 👍🏻

@scruffian scruffian merged commit 610e449 into trunk May 13, 2022
@scruffian scruffian deleted the update/use-basename-in-export branch May 13, 2022 20:33
@github-actions github-actions bot added this to the Gutenberg 13.3 milestone May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@scruffian scruffian

Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 13.3
Development

Successfully merging this pull request may close these issues.
2 participants
@scruffian @gziolo