Update attributes example: alter source children #41016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update attributes guide https://developer.wordpress.org/block-editor/how-to-guides/block-tutorial/introducing-attributes-and-editable-fields/.
Why?
There's no
children
value mentioned forsource
in official reference https://developer.wordpress.org/block-editor/reference-guides/block-api/block-attributes/#value-source.Available values are only:
– (no value) – when no source is specified then data is stored in the block’s comment delimiter.
– attribute – data is stored in an HTML element attribute.
– text – data is stored in HTML text.
– html – data is stored in HTML. This is typically used by RichText.
– query – data is stored as an array of objects.
– meta – data is stored in post meta (deprecated).
How?
All examples should be replaced by valid
source
value or attributes documentation should be updated to addchildren
value as official.Testing Instructions
source
value with official documentation https://developer.wordpress.org/block-editor/reference-guides/block-api/block-attributes/#value-sourceThere's no
source: children
mentioned.Screenshots or screencast