[List v2]: Fix outdent on empty list item if we press enter #40939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
Size Change: +1 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
May 9, 2022
|
Amazing! Thank you for finding and fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There must have been a mixup with naming
indent/outdentwhen this was implemented and just noticed that it had the opposite behavior from the wanted. This PR fixes that and outdents the list items.Testing Instructions
EnterScreenshots or screencast
Screen.Recording.2022-03-29.at.5.41.09.PM.mov
Notes
You need to enable the experiment flag for
List block v2.