Styles hook: swap out lodash methods with their JS equivalents #40918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +933 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
ramonjd
requested review from
tomasztunik,
jorgefilipecosta and
ockham
and removed request for
tomasztunik
tomasztunik
reviewed
May 9, 2022
|
Thanks for the quick and helpful review @tomasztunik! I've updated to include your suggestions 🙇 |
tomasztunik
reviewed
May 9, 2022
tomasztunik
reviewed
May 9, 2022
andrewserong
approved these changes
May 10, 2022
There was a problem hiding this comment.
Thanks for this code quality PR @ramonjd! I agree, I think it's a really good idea to reduce our dependency on lodash where there are now straightforward vanilla JS approaches. A big one for me is that things like Object.entries( skipPaths ).forEach( ( [ indicator, path ] ) => { feels much clearer even if it's slightly more verbose, and I like that the vanilla JS forEach on the entries here gives us key, value versus lodash's value, key which always felt unintuitive to me.
✅ Tests are passing
✅ Existing styles appear to be working well in both the post and site editors
✅ No errors or warnings in the console as I hacked around adding and removing properties
LGTM!
|
Thanks for the reviews @tomasztunik and @andrewserong
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Just removing a couple of lodash methods that we arguably don't require.
Why?
Just coz.
How?
Replacing:
_.map( Object, fn() )withObject.entries( object ).map( fn() )_.startsWith( String, arg )with'somestring'.startsWith( arg )_.forEach( Object, fn() )withObject.keys( Object ).forEach( fn() )_.first( Array )witharray[ 0 ]Testing Instructions
Ensure that blocks styles work on the post/site editors.
Here is some test block code:
Test HTML
Run
npm run test-unit packages/block-editor/src/hooks/test/style.js