Improve function name for finding navigation links that use the featured image #40904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #40572
@costdev added this comment after the PR was merged, I think the points all made sense so I made a follow up PR:
#40572 (comment)
Some notes on this:
block_core_post_template_uses_feature_image()
.Shouldn't this be
block_core_post_template_uses_featured_image()
?This occurs on lines 15, 23 and 66.
Loop through recursively to find blocks that use featured images.
This function tries to find one block that uses the featured image, then returns immediately.
Suggest this instead:
Determines whether a block list contains a block that uses the featured image.
Suggest this:
can be shortened to: