Try: State: Allow for save blocking #4090
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2978
This pull request seeks to explore an option for resolving autosave clobbering of Text mode content. It introduces a new save blocking mechanism which prevents saves from occurring while active. For the moment, this is implemented while changing the Text mode textarea. In the future, it could potentially be used as a mechanism for preventing autosave from occurring when an upload is in progress.
Design notes:
One major drawback of this approach is that it is not intuitive for a user to save their changes when editing within the Text mode. Further, it may be desirable for autosave to occur while editing the Text mode textarea, as long as it takes edits from the Text mode as precedent over the pending Visual mode changes. To achieve the latter, this would require some signalling from the editor to the Text mode to indicate that a save is about to occur.
Testing instructions:
Repeat testing instructions from #2978, verifying that autosave does not kick in when making edits in the textarea after switching to Text mode.