Templates: Only allow renaming user-created and non-default templates #40881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +23 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
May 6, 2022
|
Thanks for testing, @carolinan. Do you think this needs to be backported into the next RC? |
aristath
approved these changes
May 6, 2022
|
LGTM! 👍
I think it would be good to backport it, yes |
Mamaduka
added
the
Backport to WP 6.7 Beta/RC
gziolo
pushed a commit
that referenced
this pull request
May 6, 2022
|
I cherry-picked this PR for WordPress 6.0 RC2 release with c844c75. |
gziolo
removed
the
Backport to WP 6.7 Beta/RC
30 tasks
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #40876.
PR disabled the title editing field for WP default templates and custom templates defined by the theme.
Why?
Renaming these templates will break pages/views assigned to them.
How?
Updates check to use both
is_customandhas_theme_fileproperties.is_customproperty is true when the template isn't in the list of default WP templates.has_theme_fileis set for templates that have corresponding theme files.Testing Instructions
Instructions for the issue.
Additional testing:
Screenshots or screencast