Site Editor: Avoid previous content flash when a new template is created #40841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: +17 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
fix/site-editor-content-flash
branch
from
374f664 to
906f12d
Compare
jameskoster
approved these changes
May 5, 2022
kevin940726
approved these changes
May 6, 2022
There was a problem hiding this comment.
Thanks for the fix!
setTemplate always feels a bit weird to me in this context though. We have both history and setTemplate/setPage/setTemplatePart, but I think we should only have one of them at a time. I guess it might be too big of a change to refactor it now so this fix makes sense to me 👍
|
@kevin940726, do you remember why we never swapped |
Mamaduka
added
the
Backport to WP 6.7 Beta/RC
Unfortunately, I don't remember 😅. Agree it might be a good start though. |
|
I cherry-picked this PR for WordPress 6.0 RC2 release with 025ae02. |
gziolo
removed
the
Backport to WP 6.7 Beta/RC
gziolo
pushed a commit
that referenced
this pull request
May 6, 2022
…ted (#40841) * Site Editor: Avoid previous content flash when a new template is created * Pass slug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #40286.
PR fixes previous template content flash when creating a new template from the Template list view.
Why?
The site editor store retains the edited template even after navigating to the Template list view. This template is visible for a second before
URLQueryControllerupdates the store with the new one.P.S. In the future, we might want to reset the currently edited template state when the Template list view is rendered. But for now, I decided to keep the fix simple if it's cherry-picked for WP 6.0 RC.
How?
I update the template creation handler to dispatch
setTemplatebefore updating the history and navigating to the editor.Testing Instructions
Screenshots or screencast
Before
CleanShot.2022-05-05.at.12.36.48.mp4
After
CleanShot.2022-05-05.at.12.34.20.mp4