Fix Comments Form Title text alignment #40795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Block] Post Comments Form
|
Size Change: +65 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
cbravobernal
changed the title
|
This mostly works well. I am not sure that using row-reverse for the right align is the best solution:
When I test with a screen reader, activating the reply link skips past the cancel reply link inside the H3 heading and directly to the comment text area, so I don't think the row-reverse makes a difference for that use case. |
Thanks for the review @carolinan , I thought the same, let's remove display flex and use native text alignment CSS property. |
cbravobernal
force-pushed
the
fix/comments-title-text-alignment
branch
from
fed7a61 to
8fae7a5
Compare
ockham
approved these changes
May 9, 2022
ockham
added
the
Backport to WP 6.7 Beta/RC
|
I cherry-picked this to wp/6.0 branch to be included in WordPress 6.0 RC2 later today ed9df58 |
adamziel
pushed a commit
that referenced
this pull request
May 10, 2022
adamziel
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix the alignment of the comment reply title. This appears on Comments Form block.
Complements #40613
Why?
Now when you change the alignment of Post Comments Form block, all its content respects that option.
How?
By updating the flex CSS so it respects the classes added at setting the alignment.
Testing Instructions
1.) Add a posts comment form block in the editor or add a Comment Query Loop, and select the comment form block.
1.) Adjust the alignment from the block tool bar. Duplicate the block and select a different alignment -repeat this for every alignment
Save and view the front.
Confirm if the alignments in the editor and front match the toolbar setting.
Screenshots or screencast
Loom Video