[RNMobile] Prevent unnecessary re-renders of RichText component due to color palettes prop
#40615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Performance
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
jhnstn
approved these changes
Apr 26, 2022
SiobhyB
pushed a commit
that referenced
this pull request
Apr 26, 2022
…o color palettes prop (#40615)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improve performance of
RichTextcomponent by preventing unnecessary re-renders.Why?
This PR addresses the issue described in #39955.
The
RichTextcomponent receives the color palettes via thecolorPaletteprop, which is calculated by flattening all the color palettes into a single array. This was made within thewithSelectblock, so it was generating a new array instance every time editor settings were updated, and therefore, re-rendering unnecessarily allRichTextcomponents withing the editor.How?
A new function
flatColorPaletteshas been added to theRichTextcomponent that memoizes the flattened color palettes.Testing Instructions
Check performance
Follow the Step-by-step reproduction instructions from #39955.
Check color palettes
Preparation:
It's recommended to use the WordPress app to check changes in the color palettes.
Screenshots or screencast
Performance comparison: