Add "How To Get Your Pull Request Reviewed?" to developer handbook #40589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Developer Documentation
adamziel
requested review from
ajitbohra,
mkaz,
ryanwelcher and
juanmaguitar
as code owners
adamziel
force-pushed
the
docs/how-to-get-your-pull-request-reviewed
branch
from
33a710e to
0e2882d
Compare
alexstine
reviewed
Apr 25, 2022
I published a [Twitter thread](https://twitter.com/adamzielin/status/1515025299133583360) on this exact topic and it received great feedback. @poena on .org slack suggested it might be a useful addition to the developer's handbook, and so this PR adds a new page explaining how to create effective PRs.
adamziel
force-pushed
the
docs/how-to-get-your-pull-request-reviewed
branch
from
0e2882d to
5ef05d6
Compare
|
There is a similar section in the Repository Management document: It probably needs to be updated there or cross-linked between those two. |
priethor
requested changes
Apr 25, 2022
|
|
||
| It’s the easiest way to get on others’ radar. | ||
|
|
||
| Look up the PRs of folks listed in the previous tweet and review them. |
There was a problem hiding this comment.
The tweet reference here is out of context.
|
Great feedback @priethor, thank you! I'll adjust the writing and ping you |
getdave
reviewed
Apr 26, 2022
There was a problem hiding this comment.
This is good stuff. Just laying it out may help folks less experienced with working in the project (or in OS in general) to understand
- how to get their PR reviewed
- common pitfalls
- why their currently PR isn't getting the attention they feel it deserves.
Left some comments.
|
Great review, @getdave ! These small changes convey a tone that better matches the Handbook 👌 |
Co-authored-by: Héctor <[email protected]>
Co-authored-by: Héctor <[email protected]>
Co-authored-by: Héctor <[email protected]>
Co-authored-by: Dave Smith <[email protected]>
Co-authored-by: Dave Smith <[email protected]>
Co-authored-by: Dave Smith <[email protected]>
Co-authored-by: Dave Smith <[email protected]>
Co-authored-by: Dave Smith <[email protected]>
…om:WordPress/gutenberg into docs/how-to-get-your-pull-request-reviewed
annezazu
reviewed
May 4, 2022
docs/contributors/code/how-to-get-your-pull-request-reviewed.md
Outdated
Show resolved
Hide resolved
priethor
approved these changes
May 5, 2022
adamziel
force-pushed
the
docs/how-to-get-your-pull-request-reviewed
branch
from
e2944e0 to
5d258da
Compare
|
Great work on this one 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving?
I wrote a "tutorial" to solve a common struggle – attracting a code review.
How does your PR solve it?
By adding a new handbook page. It contains the same tips as my popular Twitter thread. @carolinan on .org slack suggested it might be a useful addition to the developer's handbook, so here it is.
What feedback do you need?
How to test?
cc @atachibana @carolinan @t-hamano @talldan @gziolo @getdave @ryanwelcher @mkaz