Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alignment issue with the comment reply link #40582

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Fix alignment issue with the comment reply link #40582

merged 1 commit into from
Apr 26, 2022

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Apr 25, 2022 •
edited
Loading

What?

Assures that the comment reply link text alignment setting works and that the block displays correctly on the front.
Also removes duplicate escaping.

Partial for #40271 #40269

Why?

The block had duplicate has-x-large-font-size classes on the front. This caused the alignment class and the font size class to be output as one word without spacing in between them, and the CSS was not applied. Because of this, the alignment option did not work.

How?

By removing the extra output of the font size class, the class name for the text alignment is correct and the CSS applied.

Testing Instructions

  1. Add a comment query loop to a post or page that has comments.
  2. Select the inner comment reply link block.
  3. Test the toolbar option for text alignment.
  4. Test the font size option in the block settings sidebar.
  5. Save and view the front. Confirm that both the text alignment and the font size works.

Screenshots or screencast

After:
Font size, colors and text alignment works:
image

@carolinan
Fix alignment issue with the comment reply link
e6d1ac7 
Removes duplicate font size class.
@carolinan carolinan requested a review from ajitbohra as a code owner April 25, 2022 10:21
@carolinan carolinan added [Type] Bug An existing feature does not function as intended [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop labels Apr 25, 2022
This was referenced Apr 25, 2022
Merged
Merged
cbravobernal
cbravobernal approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbravobernal cbravobernal merged commit 59072a5 into trunk Apr 26, 2022
@cbravobernal cbravobernal deleted the update/comment-reply-classes branch April 26, 2022 09:42
@github-actions github-actions bot added this to the Gutenberg 13.2 milestone Apr 26, 2022
adamziel pushed a commit that referenced this pull request Apr 26, 2022
@carolinan @adamziel
Fix alignment issue with the comment reply link (#40582)
3bbc756 
Removes duplicate font size class.
@adamziel
Copy link
Contributor

This was backported to wp/6.0 branch to be included in WordPress 6.0 Beta 3 today: 3bbc756

@carolinan carolinan mentioned this pull request Apr 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbravobernal cbravobernal cbravobernal approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@carolinan carolinan

Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.0 Editor Tasks
Archived in project
Milestone
Gutenberg 13.2
Development

Successfully merging this pull request may close these issues.
3 participants
@carolinan @adamziel @cbravobernal