Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off WP 6.0 stopgap handler to use Webfonts API. #40555

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Turn off WP 6.0 stopgap handler to use Webfonts API. #40555

merged 3 commits into from
Apr 26, 2022

Conversation

hellofromtonya
Copy link
Contributor

@hellofromtonya hellofromtonya commented Apr 22, 2022 •
edited
Loading

Part of #40472.

What?

Turns off WordPress 6.0's theme.json webfonts handler (the stopgap implementation).

Why?

To allow the Webfonts API in Gutenberg to run instead.

Notes

The mechanism to turn it off is dependent upon WordPress/wordpress-develop#2622 being committed into WordPress Core trunk.

@hellofromtonya hellofromtonya mentioned this pull request Apr 22, 2022
Closed
7 tasks
@hellofromtonya hellofromtonya self-assigned this Apr 22, 2022
gziolo
gziolo approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I moved it to 6.0 then back to experimental. It was correctly placed as it needs to be colocated with the code that adds the full Webfonts API.

@gziolo gziolo merged commit ff8dbda into trunk Apr 26, 2022
@gziolo gziolo deleted the try/disable-stopgap-theme-json-webfonts-handler branch April 26, 2022 09:15
@github-actions github-actions bot added this to the Gutenberg 13.2 milestone Apr 26, 2022
@georgeh georgeh added the [Type] Enhancement A suggestion for improvement. label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@adamziel adamziel Awaiting requested review from adamziel

Assignees

@hellofromtonya hellofromtonya

Labels
[Type] Enhancement A suggestion for improvement.
Projects
No open projects
WordPress 6.0 Editor Tasks
Archived in project
Milestone
Gutenberg 13.2
Development

Successfully merging this pull request may close these issues.
3 participants
@hellofromtonya @gziolo @georgeh