Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testid and update tests #40534

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Remove testid and update tests #40534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/block-library/src/comment-template/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,11 +288,7 @@ export default function CommentTemplateEdit( {
}

if ( ! commentTree.length ) {
return (
<p { ...blockProps } data-testid="noresults">
{ __( 'No results found.' ) }
</p>
);
return <p { ...blockProps }>{ __( 'No results found.' ) }</p>;
}

return (
Expand Down
8 changes: 1 addition & 7 deletions packages/e2e-tests/specs/editor/blocks/comments-query.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,7 @@ describe( 'Comment Query Loop', () => {
await trashAllComments();
await createNewPost();
await insertBlock( 'Comments Query Loop' );
await page.waitForSelector( '[data-testid="noresults"]' );
expect(
await page.evaluate(
( el ) => el.innerText,
await page.$( '[data-testid="noresults"]' )
)
).toEqual( 'No results found.' );
await page.waitForXPath( '//p[contains(text(), "No results found.")]' );
} );
it( 'Pagination links are working as expected', async () => {
await createNewPost();
Expand Down