Scripts: Remove deprecated format-js command
#40512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
gziolo
added
[Tool] WP Scripts
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
ockham
requested changes
Apr 21, 2022
gziolo
commented
Apr 21, 2022
| * src/index.js – for our JavaScript application | ||
| * style.css – for the minimal stylesheet | ||
| * package.json – for the build process | ||
| - my-first-gutenberg-app.php – to create a new admin page |
There was a problem hiding this comment.
I have Prettier integrated with my IDE and this is why these changes got included. It's also surprising because all Markdown files were formatted with Prettier a few months ago...
There was a problem hiding this comment.
Yeah, that's kinda weird 🤔 I hope that we don't end up accidentally using different configs for prettier/markdown in our scripts and in our editor configs.
Anyway, it's just whitespace 😬 Even if this wasn't the format we want, it wouldn't be the end of the world.
ockham
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
format-jscommand from@wordpress/scriptsgot deprecated and replaced withformatin #30240. It's about time to remove it completely as it's been almost a year since it happened. It was undocumented all that time so the old projects would already notice the warning.Why?
It's no longer used.
How?
Removes the code.