Remove logic preventing the toolbar from hiding when typing within formats #40476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ellatrix,
cameronvoell,
ajitbohra,
mkaz,
ryanwelcher and
juanmaguitar
as code owners
|
Size Change: -158 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
mcsf
approved these changes
Apr 20, 2022
bph
added
the
Needs Dev Note
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a cleanup PR, while working on the block toolbar, I noticed that we have logic in place that prevents the toolbar from hiding when we type within formats (bold, italic...). This PR removes that logic.
Why?
It's really unclear to me why we had that special case in place, it's very old. I'm hoping that by opening the PR, some e2e test could start failing if it's really important.
For me I don't see why formatted text should be treated differently here.
How?
I also decided to deprecate the selectors and actions and remove the logic keeping that value in state. I checked in wpdirectory.net and no one is really using this, the only results are plugins that actually are bundling Gutenberg.
Testing Instructions
you can type within a formatted text and the toolbar gets hidden unless you move the mouse.