-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Featured Image: Use translatable post type label #40378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
An existing feature does not function as intended
Internationalization (i18n)
Issues or PRs related to internationalization efforts
[Block] Post Featured Image
Affects the Post Featured Image Block
labels
Apr 15, 2022
Size Change: +21 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Apr 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks George! I left a small comment but this looks good!
Mamaduka
added
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Apr 15, 2022
adamziel
pushed a commit
that referenced
this pull request
Apr 19, 2022
adamziel
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Apr 19, 2022
This was cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Post Featured Image
Affects the Post Featured Image Block
Internationalization (i18n)
Issues or PRs related to internationalization efforts
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves #40375.
PR fixes a bug where the post type name wasn't translated in "Link settings."
How?
Updated code to use the translatable label from the store instead of the post-type slug.
P.S. Similar method is used in the Post Date block.
Testing Instructions
Link to {postTypeLabel}
is correctly displayed in Link settings.Screenshots or screencast