DocumentSettingPanel: Remove plugin icon fallback #40355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.23 MB ℹ️ View Unchanged
|
ryanwelcher
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR removes fallback to plugin context icon.
Why?
Core panels don't display icons next to the labels. So the fallback required explicitly setting plugin icon to falsy value so that default icon wasn't displayed.
I think default behavior should match core document panels but allow developers to specify the icon.
cc @ryanwelcher
Testing Instructions
2 Register document settings panel using a snippet from docs - https://developer.wordpress.org/block-editor/reference-guides/packages/packages-edit-post/#plugindocumentsettingpanel.
Screenshots or screencast