Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block Library: Deprecate the Post Comments block #40167

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Block Library: Deprecate the Post Comments block #40167

merged 2 commits into from
Apr 8, 2022

Conversation

DAreRodz
Copy link
Contributor

@DAreRodz DAreRodz commented Apr 7, 2022 •
edited
Loading

What?

Removes the Post Comments block from the inserter, now that we have Comments Query Loop to replace it.

Why?

That block is being replaced with Comments Query Loop.

How?

Simply adding "inserter": false in block.json. The title and description have been updated as well to reflect that the block is deprecated.

Testing Instructions

  1. Open a Post or Page, or go to any template.
  2. Check that the Post Comments block doesn't appear anymore.
  3. Add a Post Comments block using the Code Editor.
  4. Check that the title and description of the block tell the block is deprecated.

Screenshots or screencast

Searching in the block inserter:

Screenshot 2022-04-08 at 11 01 42

Block information card:

Screenshot 2022-04-08 at 11 03 06

carolinan
carolinan requested changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi
I believe the title and description should also be updated, like we did for the post comment block?
#36032

@DAreRodz DAreRodz added the [Feature] Blocks Overall functionality of blocks label Apr 8, 2022
@DAreRodz
Copy link
Contributor Author

DAreRodz commented Apr 8, 2022

Yup, that would be much better. Thanks for noticing, @carolinan. 😊

@DAreRodz DAreRodz added [Type] Enhancement A suggestion for improvement. [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Block] Comments (legacy) The legacy mode of the Comments block (formerly known as Post Comments) and removed [Feature] Blocks Overall functionality of blocks labels Apr 8, 2022
@DAreRodz DAreRodz changed the title Post Comments: Hide block in the inserter Block Library: Deprecate the Post Comments block Apr 8, 2022
@DAreRodz DAreRodz requested a review from carolinan April 8, 2022 09:07
@ZebulanStanphill ZebulanStanphill merged commit 93c3914 into trunk Apr 8, 2022
@ZebulanStanphill ZebulanStanphill deleted the update/hide-post-comments-block branch April 8, 2022 19:29
@github-actions github-actions bot added this to the Gutenberg 13.1 milestone Apr 8, 2022
@ZebulanStanphill ZebulanStanphill added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Apr 8, 2022
adamziel pushed a commit that referenced this pull request Apr 11, 2022
@DAreRodz @adamziel
Block Library: Deprecate the Post Comments block (#40167)
5826d4c 
* Remove Post Comments from the inserter

* Update block's title and description
@gziolo
Copy link
Member

gziolo commented Apr 11, 2022 •
edited
Loading

This PR was cherry-picked for Gutenberg plugin release v13.0 and WordPress 6.0 Beta 1.

@gziolo gziolo modified the milestones: Gutenberg 13.1, Gutenberg 13.0 Apr 11, 2022
@gziolo gziolo removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Apr 11, 2022
ockham added a commit that referenced this pull request Apr 22, 2022
@ockham
Revert "Block Library: Deprecate the Post Comments block (#40167)"
2027143 
This reverts commit 93c3914.
ockham added a commit that referenced this pull request Apr 25, 2022
@ockham
Revert "Block Library: Deprecate the Post Comments block (#40167)"
02b8c0a 
This reverts commit 93c3914.
@shimotmk shimotmk mentioned this pull request Apr 28, 2022
Closed
5 tasks
@ockham ockham mentioned this pull request Oct 28, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinan carolinan carolinan approved these changes

@ajitbohra ajitbohra ajitbohra approved these changes

@SantosGuillamot SantosGuillamot Awaiting requested review from SantosGuillamot

@cbravobernal cbravobernal Awaiting requested review from cbravobernal

@mkaz mkaz Awaiting requested review from mkaz

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

Assignees

@DAreRodz DAreRodz

Labels
[Block] Comments (legacy) The legacy mode of the Comments block (formerly known as Post Comments) [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Type] Enhancement A suggestion for improvement.
Projects
No open projects
WordPress 6.0 Editor Tasks
Archived in project
Milestone
Gutenberg 13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@DAreRodz @gziolo @ajitbohra @carolinan @ZebulanStanphill