Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a unit test for wp_recursive_ksort #40149

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Conversation

scruffian
Copy link
Contributor

What?

This was added in #39842, but without a unit test, so this PR adds the test.

Why?

All new functions in core need unit tests.

How?

Compare the result of calling the function with a static array.

Testing Instructions

Check the tests pass.

@scruffian scruffian requested a review from adamziel April 7, 2022 13:39
@scruffian scruffian self-assigned this Apr 7, 2022
@gziolo gziolo added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. labels Apr 7, 2022
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's land as soon as CI turns green 👍🏻

Thank you so much 🙇🏻

@gziolo gziolo added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Apr 7, 2022
@gziolo gziolo merged commit f013bd3 into trunk Apr 7, 2022
@gziolo gziolo deleted the add/unit-test-for-recursive-ksort branch April 7, 2022 14:20
@github-actions github-actions bot added this to the Gutenberg 13.0 milestone Apr 7, 2022
@gziolo gziolo removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Apr 11, 2022
@gziolo
Copy link
Member

gziolo commented Apr 11, 2022

Changes will get backported to WP core with WordPress/wordpress-develop#2534.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants