Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a context param to sidebar entity request #40148

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

jsnajdr
Copy link
Member

@jsnajdr jsnajdr commented Apr 7, 2022

Adds a context=edit query parameter to sidebar entity definition. The server endpoint supports context, other entity requests use the context param, and also this change makes the request match with what the edit-widgets page preloads during initialization. That preload is currently wasted, because the actual request is different.

Related Core PR that improves the preloads: WordPress/wordpress-develop#2531

@jsnajdr jsnajdr requested a review from nerrad as a code owner April 7, 2022 13:15
@jsnajdr jsnajdr self-assigned this Apr 7, 2022
@jsnajdr jsnajdr requested a review from adamziel April 7, 2022 13:15
@jsnajdr jsnajdr force-pushed the update/sidebar-entity-params branch from f7aceeb to 359c606 Compare April 12, 2022 06:29
@jsnajdr jsnajdr requested a review from gziolo April 12, 2022 08:38
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you :)

@gziolo gziolo added [Type] Performance Related to performance efforts [Package] Core data /packages/core-data labels Apr 12, 2022
@jsnajdr jsnajdr merged commit c0df238 into trunk Apr 12, 2022
@jsnajdr jsnajdr deleted the update/sidebar-entity-params branch April 12, 2022 08:50
@github-actions github-actions bot added this to the Gutenberg 13.1 milestone Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Core data /packages/core-data [Type] Performance Related to performance efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants