Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNMobile] Upgrade to AztecAndroid 1.5.7 #40099

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Apr 6, 2022

Related PRs

What?

Update AztecAndroid to v.1.5.6

Why?

To keep this dependency up to date.

How?

Bump the version number (easy part 🙂 ) and test our rich text blocks (not-so-easy part 😅 ).

Testing Instructions

Generally test the writing experience with rich text blocks. Our manual writing flow tests are probably a good source of guidance for what may be worth testing here although I don't think we necessarily need to go through all of them.

@mchowning mchowning added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Mobile App - Automation Label used to initiate Mobile App PR Automation labels Apr 6, 2022
@mchowning mchowning requested a review from AmandaRiu April 6, 2022 18:02
Copy link
Contributor

@AmandaRiu AmandaRiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes in aztec were heavily tested in their original PRs and wordpress PR tested and approved by Vojta and also tested by @mchowning so I feel confident in approving this PR. :shipit:

@mchowning mchowning force-pushed the rnmobile/aztec_1.5.6 branch from d5fb1c3 to 87d8943 Compare April 15, 2022 13:45
@mchowning mchowning changed the title [RNMobile] Upgrade to AztecAndroid 1.5.6 [RNMobile] Upgrade to AztecAndroid Apr 15, 2022
@mchowning mchowning changed the title [RNMobile] Upgrade to AztecAndroid [RNMobile] Upgrade to AztecAndroid 1.5.7 Apr 15, 2022
@mchowning mchowning marked this pull request as ready for review April 15, 2022 16:25
@mchowning mchowning merged commit fec0c1d into trunk Apr 15, 2022
@mchowning mchowning deleted the rnmobile/aztec_1.5.6 branch April 15, 2022 16:25
@github-actions github-actions bot added this to the Gutenberg 13.1 milestone Apr 15, 2022
SiobhyB pushed a commit that referenced this pull request Apr 26, 2022
* Update aztec to reference 1.5.6 PR

* Update Aztec to 1.5.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - Automation Label used to initiate Mobile App PR Automation Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants