Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Logo: Correctly reset the site icon #40046

Merged
merged 5 commits into from
Apr 6, 2022
Merged

Site Logo: Correctly reset the site icon #40046

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5606e4a
fixed site icon issue in site editor
akasunil Apr 5, 2022
dd671e9
lint fix in edit js
akasunil Apr 5, 2022
e593d0a
Replace assignment with nullish coalescing
akasunil Apr 5, 2022
2e42473
optimized code
akasunil Apr 5, 2022
39b379d
lint fix
akasunil Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/block-library/src/site-logo/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,10 +416,12 @@ export default function LogoEdit( {
} );
};

const setIcon = ( newValue ) =>
const setIcon = ( newValue ) => {
newValue = newValue === undefined ? null : newValue;
Mamaduka marked this conversation as resolved.
Show resolved Hide resolved
editEntityRecord( 'root', 'site', undefined, {
site_icon: newValue,
Mamaduka marked this conversation as resolved.
Show resolved Hide resolved
} );
};

let alt = null;
if ( mediaItemData ) {
Expand Down