Site Logo: Fix adding the site icon #40041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression introduced in the `lib` folder refactoring #39972.
gziolo
added
Gutenberg Plugin
jasmussen
approved these changes
Apr 5, 2022
|
Thanks for the fix! It'd be good to add a test for this at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Regression introduced in the
libfolder refactoring #39972.Why?
My mistake. I didn't copy all functions correctly.
How?
I copied the missing function. I also prefixed other functions that don't start with
gutenberg_to prevent potential redeclarations when the same function would get added in WP core.Testing Instructions
Steps to verify the fix:
The W should be replaced by a round-rectangle site logo instead.