-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global Styles Sidebar: tweak preview box #39978
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Type] Enhancement
A suggestion for improvement.
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
labels
Apr 1, 2022
Size Change: +126 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
ciampo
changed the title
Global Styles Sidebar: tweak preview box size
Global Styles Sidebar: tweak preview box
Apr 1, 2022
ciampo
force-pushed
the
fix/global-styles-sidebar-preview-size
branch
from
April 1, 2022 13:56
9ceb158
to
db7f5c0
Compare
jasmussen
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review, @jasmussen !
Just pushed an update to fix that — I'll wait for CI checks to ✅ and merge Update: native e2e tests failures didn't seem related, merging anyway |
7 tasks
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR tweaks a few aspects around the preview box in the Global Styles sidebar, as flagged in #38934:
248x152
32x32
Why?
This is in order to follow the design specs highlighted in #38934
How?
normalizedWidth
from250
to248
px150
to152
px, and extracted to a new localnormalizedHeight
variable32
px, and extracted to a new localnormalizedColorSwatchSize
variableTesting Instructions
248 x 152
px32
pxScreenshots or screencast