useSelect: two code improvements #39975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Code Quality
|
Size Change: -7 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
I think the original name of trapSelect was not a typo but I think both are fine. cc @kevin940726
|
My own investigation also found that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two code improvements that I found when working on the
useSuspenseSelecthook in #37261:onChangefunction is exactly duplicated just a few lines above. Deduplicating that by callingonChangedirectly.trapSelect(renamed towrapSelectbecause the old name seems to be a typo) now takes themapSelectcallback as a parameter, and doing the call with( registry.select, registry)internally, instead of duplicating it on every call.