Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid automatic saving of uncontrolled Nav blocks #39883

Merged
merged 15 commits into from
Apr 5, 2022
Merged

Avoid automatic saving of uncontrolled Nav blocks #39883

merged 15 commits into from
Apr 5, 2022

Commits on Apr 4, 2022

  1. Only convert uncontrolled inner blocks if there are changes

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    4f66947 View commit details
    Browse the repository at this point in the history

  2. Show notification on conversion to entity

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    dc6b692 View commit details
    Browse the repository at this point in the history

  3. Disable inner blocks only when being converted

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    873310a View commit details
    Browse the repository at this point in the history

  4. Limit blocks to match controlled inner blocks

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    96271bf View commit details
    Browse the repository at this point in the history

  5. Add test

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    08b3f93 View commit details
    Browse the repository at this point in the history

  6. Remove Disable state on uncontrolled inner blocks

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    cdf5bdd View commit details
    Browse the repository at this point in the history

  7. Avoiding setting ref in component body 

    React docs explain this can lead to undesired side effects
    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    0e9dd0c View commit details
    Browse the repository at this point in the history

  8. Match render appender with normal inner blocks

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    7aed02d View commit details
    Browse the repository at this point in the history

  9. Disable inner blocks when saving

    @getdave
    getdave committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    b44cbe1 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Avoid createElement 

    Kudos @talldan #39883 (comment)
    @getdave
    getdave committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    042ac20 View commit details
    Browse the repository at this point in the history

  2. Update tests to check modifying inner blocks creates entity

    @getdave
    getdave committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    602d5ae View commit details
    Browse the repository at this point in the history

  3. Remove invalid test 

    You cannot reset a block that has uncontrolled inner blocks
    @getdave
    getdave committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    6b31f26 View commit details
    Browse the repository at this point in the history

  4. Improve comment for purpose of uncontrolled blocks

    @getdave
    getdave committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    b8fd1cb View commit details
    Browse the repository at this point in the history

  5. Check for button being enable before converting Page List

    @getdave
    getdave committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    2b393e0 View commit details
    Browse the repository at this point in the history

  6. Update snapshots

    @getdave
    getdave committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    d33658f View commit details
    Browse the repository at this point in the history