Partial multi-select: fix error with dead key #39850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
[Feature] Writing Flow
|
Size Change: +1.13 kB (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
|
Hm, a quick test gave me this upon pressing my ´ dead key: Gravacao.do.ecra.2022-03-29.as.16.30.29.mov |
I should add that this is only happening for me in Safari; it seems fine in Firefox. Both macOS. |
|
@mcsf Should work in Safari now. Unfortunately it doesn't work in Chrome or Firefox, but that's fine for now. As long as there's no errors. |
Thanks, this is now working on all three browsers for me. By "working", I mean that it's not letting unwanted dead keys through in Firefox and Chrome, and that it's actually working in Safari. 👏 What's left here? I see some flaky e2e tests failing, but some concern multi-block selection. |
|
Yes, need to investigate those. Most likely around disabling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Unfortunately we can get to work composing characters over a partial multi selection in all browsers. Strangely enough it works in Safari, so we'll just let it work there. In Chrome nothing will happen. In Firefox the selection will be deleted, but no composition state is inserted. This all needs more investigation but this is the best we can do now. The most important thing is that we don't let the browser manipulate the DOM, otherwise there will be errors.
Why?
How?
Testing Instructions
Screenshots or screencast