Migrated nux.test.js to Playwright #39772
Conversation
github-actions
bot
added
the
First-time Contributor
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sandeshjangam! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
|
@kevin940726 Can you please add it in #38851 ? Your input is appreciated. |
|
Is this PR ready for review? I can see that there's still some temporary commented code. |
|
@kevin940726 PR is now ready to review. Removed all unwanted comments and code. |
There was a problem hiding this comment.
Thank you for making the PR!
Have you read the best practices guide yet? I noticed that we're still using class names and XPath selectors rather than using accessible role selectors in the tests. (We could refactor them in the future though, but I'd prefer to refactor them as we're migrating 🙂)
| @@ -37,7 +37,7 @@ const config: PlaywrightTestConfig = { | |||
| strictSelectors: true, | |||
| }, | |||
| storageState: STORAGE_STATE_PATH, | |||
| actionTimeout: 10_000, // 10 seconds. | |||
| actionTimeout: 20_000, // 20 seconds. | |||
There was a problem hiding this comment.
Why do we want to change this?
skorasaurus
added
the
[Type] Automated Testing
github-actions
bot
added
the
[Status] In Progress
What?
Based on #38570, part of #38851. New User Experience (nux) nux.test.js to its Playwright counterpart.
Note - This PR is dependent on #39748 PR. This PR or the required "create-post" utils file is required.
Why?
Migration to Playwright
How?
Migration to Playwright
Testing Instructions
npm run test-e2e:playwright -- test/e2e/specs/editor/various/nux.spec.js
Screenshots or screencast