Add x2 to url string that defines the image size by default #39728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Enhancement
|
Size Change: +35 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
|
Nice! This works well. Shown here, 96px does render the double size, ensuring always crispness. It isn't entirely visible as I resize in this GIF because the GIF is 1x resolution, but it works: While you'r in here, can you change the panel to just say "Settings"? Avatar is implied by the text above:
Not something for this PR, but the spacing between the User label/input/helptext and the toggle below is a bit tight:
On the component side, do we have any tricks here, @ciampo? |
cbravobernal
force-pushed
the
update/improve-avatar-image-quality
branch
from
ef3870d to
b3625c4
Compare
Done!
I reordered the settings and put User at the bottom (which is also the only conditional setting), which solves the margin issues. Let me know if you prefer a specific order and play with |
|
Nice! Because the code is a bit foreign to me, I'd appreciate a quick code review. But visually this is in much better shape. Thank you! 👍 👍 |
jasmussen
approved these changes
Mar 25, 2022
|
Let's wait for a code review then. I'm also not sure if there could be a better approach to this. |
michalczaplinski
approved these changes
Mar 25, 2022
Sorry for the late response @jasmussen, I was AFK in the past days! I'll still leave an answer in case we want to follow-up to the changes in this PR. As of today, we have: |
10 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Increase the size of the Avatar image to be 2x of the width chosen, in order not to get pixelated on retina displays.
Why?
Right now, WordPress by default has 3 sizes for the User Avatars:
With the new Avatar block, we allow the user up to 240px size. Causing all Avatars above 96px will get pixelated. Also, all Avatars above 48px will get pixelated on retina displays.
How?
Behind the scenes, it calls Gravatar URLs for defaults Avatars as well for custom Avatars based on user emails. Some similar to this:
http://1.gravatar.com/avatar/d7a973c7dab26985da5f961be7b74480?s=96&d=mm&r=gIf we check the URL, the query
sdefines the image size ->?s=96It seems that just by doubling that value, Gravatar will return an image of that size. So we can double it both in the editor and in the frontend (the
wp_get_avatar()function is adding thesrcsetattribute with a 2x by default).Testing Instructions
Screenshots or screencast
Editor with a 165*2 size:
Frontend with a 165 size for srcset 1x, a 165*2 for srcset2x
