-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[create-block] Add npmDevDependencies as a template variable. #39723
[create-block] Add npmDevDependencies as a template variable. #39723
Conversation
…ow what packages are being installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had a chance to test that yet. The changes proposed in the PR look great though 👍🏻
Any idea why CI jobs didn't start?
Thanks, @gziolo! Not sure about the CI either, I tried pushing another commit to restart the jobs but that did nothing. |
875e7ae
to
99f86ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updated a couple of typos.
Co-authored-by: David Gwyer <[email protected]>
For posterity, I was able to get the CI job to re-run by rebasing from |
What?
This PR adds a new template variable to the create-block package to allow templates to define
devDependencies
.Closes #39722
Why?
Some blocks require
devDependences
that should not be added to regulardependencies
.How?
This is done by introducing a
npmDevDependencies
variableTesting Instructions
npmDevDependencies
entry to the index.js and add an array of dependenciesRun ./node_modules/.bin/wp-create-block --template={pathTo}/dynamic-block-template