-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate entities.js to Typescript #39547
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Core data
/packages/core-data
Developer Experience
Ideas about improving block and theme developer experience
labels
Mar 17, 2022
adamziel
changed the title
Migrate entities.js to a Typescript
Migrate entities.js to Typescript
Mar 17, 2022
adamziel
force-pushed
the
ts/migrate-entities-config-to-typescript
branch
from
April 1, 2022 13:13
752499f
to
0ec15d3
Compare
Size Change: 0 B Total Size: 1.22 MB ℹ️ View Unchanged
|
dmsnell
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Developer Experience
Ideas about improving block and theme developer experience
[Package] Core data
/packages/core-data
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #39025
This is a minimal changeset to give
entities.js
a.ts
extension without raising any type errors. It will make the upcoming migration much easier as any merge conflicts will occur insideentities.ts
and not between the two files.Why?
We want to do great things with the
core-data
type system but reconciling conflicts between two files make any long-lived PR really hard to maintain.Testing Instructions
Confirm the types make sense and there are no type errors resulting out of this PR. No dynamic code is changed in this PR, so there is nothing to test in the browser.