-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX missing images of Gutenberg Data Apps document #39499
Conversation
Thank you for starting this PR. @adamziel should be interested to help you to bring it to the finish line. |
@gziolo Missing are in the 3-building-an-edit-form.md.
Yes. I believe this PR resolves all. |
Thank you @atachibana 💯 |
@atachibana Thank you so much! 💯 ❤️ |
@adamziel Hi, Thank you for the educational and fun tutorial. By the way, did you know the Japanese guy Aki Hamano (@t-hamano ) is doing the live-demo based on your tutorial? (Ah, sorry it is Japanese... ) |
I had no idea, thank you so much for sharing that @atachibana ❤️ @t-hamano I would love to learn more about your experience with that tutorial! Was it smooth? Confusing? Anything that was missing in your opinion, or any specific direction that you'd like to see it expanded in? I certainly have blind spots for things and your feedback would help me notice and pay attention to them. As a side note, you might be interested in the upcoming Part 4 that explains how to build a form that enables creating new pages. And by the way, the Piano Block is amazing! |
@adamziel Thank you for making a great tutorial. I'm just now putting that tutorial into practice, but I would like to send the issue or PR if there is any concern 👍 |
All images in "Create your first app with Gutenberg Data" are shown on GitHub preview, but not in the Block Editor Handbook. For example, the following page contains the image after "app will look like this:" but does not show:
https://developer.wordpress.org/block-editor/how-to-guides/data-basics/
This is because the image is specified as below:
It must be
As like as other images on doc page.
Refer https://github.com/atachibana/gutenberg/blob/master/docs/how-to-guides/plugin-sidebar-0.md.
At the same time, I also modified two minor typos.