-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preferences modal to site editor #39485
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
packages/edit-site/src/components/preferences-modal/enable-feature.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { useSelect, useDispatch } from '@wordpress/data'; | ||
import { ___unstablePreferencesModalBaseOption as BaseOption } from '@wordpress/interface'; | ||
import { store as preferencesStore } from '@wordpress/preferences'; | ||
|
||
export default function EnableFeature( props ) { | ||
const { featureName, ...remainingProps } = props; | ||
const isChecked = useSelect( | ||
( select ) => | ||
!! select( preferencesStore ).get( 'core/edit-site', featureName ), | ||
[ featureName ] | ||
); | ||
const { toggle } = useDispatch( preferencesStore ); | ||
const onChange = () => toggle( 'core/edit-site', featureName ); | ||
return ( | ||
<BaseOption | ||
onChange={ onChange } | ||
isChecked={ isChecked } | ||
{ ...remainingProps } | ||
/> | ||
); | ||
} |
71 changes: 71 additions & 0 deletions
71
packages/edit-site/src/components/preferences-modal/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
/** | ||
* WordPress dependencies | ||
*/ | ||
import { | ||
PreferencesModal, | ||
PreferencesModalTabs, | ||
PreferencesModalSection, | ||
} from '@wordpress/interface'; | ||
import { useMemo } from '@wordpress/element'; | ||
import { __ } from '@wordpress/i18n'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import EnableFeature from './enable-feature'; | ||
|
||
export default function EditSitePreferencesModal( { | ||
isModalActive, | ||
toggleModal, | ||
} ) { | ||
const sections = useMemo( () => [ | ||
{ | ||
name: 'general', | ||
tabLabel: __( 'General' ), | ||
content: ( | ||
<PreferencesModalSection | ||
title={ __( 'Appearance' ) } | ||
description={ __( | ||
'Customize options related to the block editor interface and editing flow.' | ||
) } | ||
> | ||
<EnableFeature | ||
featureName="focusMode" | ||
help={ __( | ||
'Highlights the current block and fades other content.' | ||
) } | ||
label={ __( 'Spotlight mode' ) } | ||
/> | ||
</PreferencesModalSection> | ||
), | ||
}, | ||
{ | ||
name: 'blocks', | ||
tabLabel: __( 'Blocks' ), | ||
content: ( | ||
<PreferencesModalSection | ||
title={ __( 'Block interactions' ) } | ||
description={ __( | ||
'Customize how you interact with blocks in the block library and editing canvas.' | ||
) } | ||
> | ||
<EnableFeature | ||
featureName="keepCaretInsideBlock" | ||
help={ __( | ||
'Aids screen readers by stopping text caret from leaving blocks.' | ||
) } | ||
label={ __( 'Contain text cursor inside block' ) } | ||
/> | ||
</PreferencesModalSection> | ||
), | ||
}, | ||
] ); | ||
if ( ! isModalActive ) { | ||
return null; | ||
} | ||
return ( | ||
<PreferencesModal closeModal={ toggleModal }> | ||
<PreferencesModalTabs sections={ sections } /> | ||
</PreferencesModal> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does still feel a bit empty with one setting per tab. I wonder if right now an option could be to not add the tabs until there are more settings later on, and instead render the two
PreferenceModalSection
s directly in the modal.I don't know if the styles will work out of the box, but it might be possible to make some quick fixes there.
Could be good to get some design feedback on it though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think tabs will fill up faster now that we've modal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be pretty easy to get the block manager in there as well now.
I think the component needs to be moved out of
edit-post
, but the rest of the implementation shouldn't be too difficult.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I added the second tab mainly thinking about the block manager which takes up a huge chunk of space 😄
Plus with #38317 there'll be at least one more item under Appearance soon.