Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] - Highlight text - Fix issue when moving the caret and autocorrected words #39454

Closed
wants to merge 2 commits into from

Conversation

geriux
Copy link
Member

@geriux geriux commented Mar 15, 2022

Fixes #38246

What?

This PR fixes two current issues with the highlight text feature:

  • Now moving the caret after highlighting some words won't keep the previously selected color when typing new characters.
  • Autocorrected wors will keep the highlighted color when the new entry is replaced.

Why?

While testing the highlight text feature, these issues were discovered. This PR will handle some of the reported problems.

How?

This PR updates the Aztec version that handles these bugs.

Testing Instructions

After moving the caret the default color text is restored

  • Open the app
  • Add a Paragraph block.
  • Type some text.
  • Tap on the Highlight text format button and select a color.
  • Type some more text and observe that the selected color is applied to the text written.
  • Move the caret around and place it at the end of the text.
  • Type some more text.
  • Expect the newly introduced text to have the default text color

Autocorrected words keep the highlighted style

  • Open the app
  • Add a Paragraph block
  • Type some words that will need to be autocorrected and accept the suggestions (tapping on the space bar for example) this will autocorrect it
  • Select one of the autocorrected words and toggle the Bold formatting (this is a quick way to check the color formatting is not lost)
  • Expect to see all autocorrected words to keep their highlighted colors.

Screenshots or screencast

After moving the caret the default color text is restored

Before After

Autocorrected words keep the highlighted style

Before After

@geriux geriux added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Mar 15, 2022
@geriux geriux marked this pull request as ready for review March 15, 2022 09:57
@geriux geriux added the Mobile App - Automation Label used to initiate Mobile App PR Automation label Mar 16, 2022
# Conflicts:
#	packages/react-native-editor/ios/Podfile.lock
@geriux
Copy link
Member Author

geriux commented Jan 8, 2024

Closing in favor of #57650

@geriux geriux closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight text: Format button doesn't match current color when moving the caret
1 participant