Fix: Table block doesn't keep background color #39445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +7 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
|
I think that the color palette in the core block does not work is a problem. |
aaronrobertshaw
added
the
Backport to WP Minor Release
aaronrobertshaw
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Thank you for fixing this @t-hamano 👍
✅ Can replicate the original issue
✅ After checking out this PR branch, the issue is resolved
If there is any way to avoid these edge cases, please advise.
Given when these deprecations run in the parser, I'm not sure how we can avoid this.
The isEligible function only gets passed the attributes and innerBlocks. They aren't very helpful in this case, in being able to determine if a color palette color shares the same slug as the old table colors.
Due to the severity of the current bug, I'd like to see this PR land and address the edge case in a follow-up if possible.
|
Thanks for tweaking the changelog entry @t-hamano.
I've taken another look at options to prevent this edge case but haven't found a way around it. Given this PR improves the current state of things I think we should go ahead and merge this. |
|
@aaronrobertshaw |
|
You can do the honours and merge this now @t-hamano. 👍 I've already added a backport label to this PR so it can be evaluated for that when the time comes. |
Mamaduka
pushed a commit
that referenced
this pull request
Mar 29, 2022
* Fix: Table block doesn't keep background color * add readme * update readme
Mamaduka
removed
the
Backport to WP Minor Release
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In table block, the background color is not reflected correctly in the editor if only the background color is selected from the color palette.
Why?
If only the background color is selected in the color palette, html is generated in which only the class is given to the table tag and no style attribute is given, as shown below:
Therefore, the backward-compatibility support for initial table blocks with colors such as
subtle-light-grayalso affects such HTML:How?
In this PR, the initial table block migrate is now limited to only those cases where the background color slug is included in oldColors (
subtle-light-gray/subtle-pale-green/subtle-pale-blue/subtle-pale-pink)Testing Instructions
Screenshots or screencast
before this PR ( on trunk ):
4ff7662583f52c86c9717a4602b7e437.mp4
About edge case
If the same slug is defined as the old color variation of the table in the custom color palette, it will be considered the initial table block and the oldColors color value will take precedence.
947f349a27be1d17f89d00b4418077bb.mp4
If there is any way to avoid these edge cases, please advise.