Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery block: disable edit as html support #39318

Merged
merged 2 commits into from
Mar 10, 2022
Merged

Gallery block: disable edit as html support #39318

merged 2 commits into from
Mar 10, 2022

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Mar 9, 2022

See: #39310

What?

This PR disables HTML editing support for gallery blocks.

Why?

In the gallery block, the block is broken when entering HTML edit mode and then returning to visual edit mode.
But gallery blocks with child blocks (core/image) should not be edited as HTML, just like group and column blocks.

How?

Testing Instructions

  1. Insert a gallery block.
  2. Make sure that the "Edit as HTML" menu is not displayed in the block toolbar option.

@t-hamano t-hamano marked this pull request as ready for review March 9, 2022 15:58
@Mamaduka Mamaduka linked an issue Mar 9, 2022 that may be closed by this pull request
Gallery block: Block is broken when returning from HTML edit mode to visual edit mode #39310
Closed
@Mamaduka Mamaduka added [Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended labels Mar 9, 2022
Mamaduka
Mamaduka approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks, @t-hamano 👍

@ZebulanStanphill ZebulanStanphill merged commit 53f5080 into trunk Mar 10, 2022
@ZebulanStanphill ZebulanStanphill deleted the fix/gallery-html-support branch March 10, 2022 03:36
@github-actions github-actions bot added this to the Gutenberg 12.9 milestone Mar 10, 2022
@Mamaduka Mamaduka mentioned this pull request Mar 15, 2023
Merged
@Mamaduka Mamaduka mentioned this pull request Mar 29, 2023
Merged
@shimotmk shimotmk mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@geriux geriux Awaiting requested review from geriux geriux is a code owner

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@mkaz mkaz Awaiting requested review from mkaz

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

Assignees
No one assigned
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 12.9
Development

Successfully merging this pull request may close these issues.

Gallery block: Block is broken when returning from HTML edit mode to visual edit mode
3 participants
@t-hamano @Mamaduka @ZebulanStanphill