Add tests for Editable.getSettings() #3892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BE-Webdesign
added
the
[Type] Automated Testing
gziolo
reviewed
Dec 15, 2017
blocks/editable/test/index.js
Outdated
| } ); | ||
|
|
||
| test( 'should be overriden', () => { | ||
| const mock = jest.fn().mockImplementation( ( setting ) => 'mocked' ); // eslint-disable-line no-unused-vars |
There was a problem hiding this comment.
It is perfectly valid to omit setting in function definition instead of disabling Eslint check.
There was a problem hiding this comment.
You can also pass callback to jest.fn instead of using mockImplementation. See https://facebook.github.io/jest/docs/en/mock-functions.html#mock-implementations.
const mock = jest.fn( () => 'mocked' );There was a problem hiding this comment.
Yup, makes sense.
gziolo
reviewed
Dec 15, 2017
blocks/editable/test/index.js
Outdated
| describe( 'Component', () => { | ||
| describe( '.getSettings', () => { | ||
| const value = [ 'Hi!' ]; | ||
| const wrapper = shallow( <Editable value={ value } /> ); |
There was a problem hiding this comment.
This wrapper is used only in one tests. It would be better to put it there, because the other tests uses a different wrapper.
gziolo
approved these changes
Dec 15, 2017
BE-Webdesign
force-pushed
the
add/test/blocks/editable-2
branch
2 times, most recently
from
db8142e to
e8e7eb1
Compare
BE-Webdesign
force-pushed
the
add/test/blocks/editable-2
branch
from
e8e7eb1 to
b393dbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for Editable.getSettings()